kkofler (Kevin Kofler)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Mar 18 2017, 9:23 AM (148 w, 10 h)
Availability
Available

Recent Activity

Thu, Jan 9

kkofler added a comment to D26550: Patch for possible resolution of https://bugs.kde.org/show_bug.cgi?id=416037.

Looks reasonable.

Thu, Jan 9, 10:31 PM · KDE Edu

Wed, Jan 1

kkofler added inline comments to D26333: Fix assertion failure when creating a python script in kig.
Wed, Jan 1, 2:50 PM · KDE Edu

Sat, Dec 21

kkofler added a comment to R875:b9fb89a31ca6: Remove GnomeKeyringPasswords plugin.

Modern distributions no longer have the deprecated library in repos.

Sat, Dec 21, 1:33 AM

Aug 24 2019

kkofler added a comment to D8810: Do not look for kioslave binary in applicationDirPath on *nix (#386859).

If you ask me (there are 2 Kevins on this bug), I think this will work. I think it's kinda overkill (it pretty much defeats the point of having version-specific libexecdirs if we end up renaming the binaries anyway), but if it works (which should be the case), I'm OK with it.

Aug 24 2019, 9:15 PM · Frameworks

May 9 2019

kkofler added a comment to T10812: KDE Applications.

LTS distros can upgrade software to new releases. RHEL regularly does this for some components, such as GNOME, lately even Qt (Qt 5 was upgraded from 5.6 LTS to 5.9 LTS in RHEL 7, I'd hope they'll do 5.12 LTS too at some point, though with RHEL 8 having been released, they might also stop upgrading RHEL 7 that way, so I don't know). What components they do that with is purely a policy decision.

May 9 2019, 10:22 AM

Mar 23 2019

kkofler added a comment to D17947: Export the APIs needed to build Blogilo again.

When you look at how simple and uninvasive the change is (it just exports code that is there anyway) and that it actually only restores backwards source and binary compatibility (which is normally considered a good thing in KDE land, it would even be mandatory if this were an official KDE Framework), I think you (all three) are really being unhelpful and uncooperative here.

Mar 23 2019, 9:18 AM · KDE PIM

Jan 3 2019

kkofler added a comment to D17947: Export the APIs needed to build Blogilo again.

I am trying to resurrect Blogilo in Fedora. I am upgrading from the EOL Fedora 27 to the supported Fedora 28 (and eventually 29) and noticed that Blogilo was going away. So I tracked it down to the build failure caused by this export removal. I already got it building in my Kannolo Copr repository.

Jan 3 2019, 9:54 PM · KDE PIM
kkofler requested review of D17947: Export the APIs needed to build Blogilo again.
Jan 3 2019, 9:05 PM · KDE PIM
kkofler added a comment to D17947: Export the APIs needed to build Blogilo again.

Or are there different interfaces that Blogilo should be using instead? If so, which are they? There is no documentation on that.

Jan 3 2019, 8:57 PM · KDE PIM
kkofler added a comment to D17947: Export the APIs needed to build Blogilo again.

Exporting these classes is all that is needed to keep Blogilo working. There is no practical reason to break backwards compatibility of the KPIMTextEdit library that way, your only rationale for removing the exports is that they "should not be needed". The classes still exist either way.

Jan 3 2019, 8:55 PM · KDE PIM
kkofler requested review of D17947: Export the APIs needed to build Blogilo again.
Jan 3 2019, 6:57 PM · KDE PIM
kkofler added a comment to D8810: Do not look for kioslave binary in applicationDirPath on *nix (#386859).

Ping? This has been stuck for over a year now.

Jan 3 2019, 6:42 PM · Frameworks

May 13 2018

kkofler added a comment to D12846: KWalletPasswords, GnomeKeyringPasswords: Implement migration from QupZilla.

Are you going to do the merge of my changes to master or shall I do it?

May 13 2018, 10:26 AM · Falkon
kkofler committed R875:774dbf93decc: KWalletPasswords, GnomeKeyringPasswords: Implement migration from QupZilla (authored by kkofler).
KWalletPasswords, GnomeKeyringPasswords: Implement migration from QupZilla
May 13 2018, 10:23 AM
kkofler closed D12846: KWalletPasswords, GnomeKeyringPasswords: Implement migration from QupZilla.
May 13 2018, 10:23 AM · Falkon
kkofler added a comment to D12846: KWalletPasswords, GnomeKeyringPasswords: Implement migration from QupZilla.

Note: This patch is against Falkon/3.0. (The profile migration was added in 3.0.1, so I think this is also 3.0 material.) For master, the KWalletPasswords changes have to move to KDEFrameworkIntegration.

May 13 2018, 10:04 AM · Falkon
kkofler requested review of D12846: KWalletPasswords, GnomeKeyringPasswords: Implement migration from QupZilla.
May 13 2018, 10:02 AM · Falkon

May 12 2018

kkofler committed R875:d06a0d60e0ff: Fix the fix for #391300 to require only QtWebEngine 5.10, not Qt 5.10 (authored by kkofler).
Fix the fix for #391300 to require only QtWebEngine 5.10, not Qt 5.10
May 12 2018, 11:30 AM
kkofler closed D12833: Fix the fix for #391300 to require only QtWebEngine 5.10, not Qt 5.10.
May 12 2018, 11:30 AM · Falkon
kkofler updated the diff for D12833: Fix the fix for #391300 to require only QtWebEngine 5.10, not Qt 5.10.

This version now uses #cmakedefine01 as requested.

May 12 2018, 11:14 AM · Falkon
kkofler added a comment to D12833: Fix the fix for #391300 to require only QtWebEngine 5.10, not Qt 5.10.

Wouldn't it make sense to port the existing PORTABLE_BUILD and DISABLE_DBUS defines too, then? But that's material for a separate commit in any case.

May 12 2018, 11:02 AM · Falkon
kkofler added a comment to D12833: Fix the fix for #391300 to require only QtWebEngine 5.10, not Qt 5.10.

Also, all the existing macros in config.h.cmake are #cmakedefine, not #cmakedefine01, so are you sure you want the latter even though it would be inconsistent?

May 12 2018, 10:25 AM · Falkon
kkofler added a comment to D12833: Fix the fix for #391300 to require only QtWebEngine 5.10, not Qt 5.10.

I don't see a 5.11 check anywhere, at least in Falkon/3.0.

May 12 2018, 9:10 AM · Falkon
kkofler requested review of D12833: Fix the fix for #391300 to require only QtWebEngine 5.10, not Qt 5.10.
May 12 2018, 1:33 AM · Falkon

Jan 21 2018

kkofler committed R623:f2e7381105e2: Fix build with PackageKit-Qt 1.0.x (authored by kkofler).
Fix build with PackageKit-Qt 1.0.x
Jan 21 2018, 2:26 AM

Nov 14 2017

kkofler added a comment to D8810: Do not look for kioslave binary in applicationDirPath on *nix (#386859).

And the historical reason the name was not suffixed is because the binary was moved to a private libexec subdirectory to prevent conflicts. This worked fine as long as /usr/bin did not end up in the search path (in particular, for the whole 4.x series).

Nov 14 2017, 1:17 PM · Frameworks
kkofler added a comment to D8810: Do not look for kioslave binary in applicationDirPath on *nix (#386859).

Yeah, that was done to be able to provide win/linux install bundles.

Nov 14 2017, 1:12 PM · Frameworks
kkofler updated the diff for D8810: Do not look for kioslave binary in applicationDirPath on *nix (#386859).

So, since this line makes sense on Windows/Mac, let's only get rid of it on Q_OS_UNIX then.

Nov 14 2017, 1:06 PM · Frameworks
kkofler created D8810: Do not look for kioslave binary in applicationDirPath on *nix (#386859).
Nov 14 2017, 2:43 AM · Frameworks

Apr 7 2017

kkofler added a comment to D4634: Disallow executing kate and kwrite as root on Linux.

Sorry, but printing errors to stdout in a GUI application does not make sense. The users will not see them in most cases. Even if you run kdesu (without -t) from a Konsole, it will still not show stdout. There is no alternative to bringing up at least a GUI dialog (other than just stopping patronizing the user that way to begin with). Printing the recommended alternative to somewhere the user will not see is not helpful at all. The user will just see an application that does not run and have no idea why nor how to fix it.

Apr 7 2017, 7:23 PM

Mar 22 2017

kkofler added a comment to D5110: [KompareDiff2 Library]: Fix issues with blending diffs with files or folders.

Well, I think that in the present case, a single review is acceptable, but it needs to work in all situations. Unfortunately, I don't think your current code satisfies this requirement.

Mar 22 2017, 5:57 PM
kkofler added a comment to D5110: [KompareDiff2 Library]: Fix issues with blending diffs with files or folders.

And also, you are again trying to fix 2 bugs in one review request. Please submit one review per issue you fix.

Mar 22 2017, 9:51 AM
kkofler added a comment to D5110: [KompareDiff2 Library]: Fix issues with blending diffs with files or folders.

Unfortunately, I don't think your approach at taking the common part of source and destination as the directory and file name is going to work in all cases:

  • If a file was added or removed, the source resp. destination will be /dev/null.
  • Some revision control systems track renames and moves and output them as a diff section with different source and destination.
Mar 22 2017, 9:48 AM

Mar 18 2017

kkofler accepted D5096: [Kompare] Fix the file choosing dialog not handling folders to compare anymore.

Fine with me. I'm not sure what the VDG would say about the UI design, but I cannot think of a better solution either, so I think this is OK.

Mar 18 2017, 11:56 AM
kkofler accepted D5095: [Kompare] Fix Kompare not remembering settings and latest compared files.

Looks OK to me, I think the hardcoded 10 is not an issue.

Mar 18 2017, 11:54 AM
kkofler retitled D5096: [Kompare] Fix the file choosing dialog not handling folders to compare anymore from [Kompare] The Filechoosing-dialoug cannot handly folders to compare anymore to [Kompare] Fix the file choosing dialog not handling folders to compare anymore.
Mar 18 2017, 11:52 AM
kkofler retitled D5095: [Kompare] Fix Kompare not remembering settings and latest compared files from [Kompare] Kompare don't remember settings and lastest comparing files to [Kompare] Fix Kompare not remembering settings and latest compared files.
Mar 18 2017, 11:51 AM
kkofler added a comment to D5075: [Kompare] Rework on Files Page and save recently opened URLs.

Well, my first nitpick is that you are fixing 2 separate bugs and so should be submitting 2 separate code reviews.

Mar 18 2017, 9:41 AM
kkofler updated the summary of D5075: [Kompare] Rework on Files Page and save recently opened URLs.
Mar 18 2017, 9:39 AM
kkofler added a comment to D5075: [Kompare] Rework on Files Page and save recently opened URLs.

I am still the maintainer, though to be honest, I haven't done much to Kompare lately.

Mar 18 2017, 9:35 AM
kkofler added a reviewer for D5075: [Kompare] Rework on Files Page and save recently opened URLs: kkofler.
Mar 18 2017, 9:29 AM