Remove unused/unneeded includes & forward declarations
ClosedPublic

Authored by kossebau on Mar 16 2017, 5:45 PM.

Details

Summary

Some people play Sudoku on the train, others play
Gredelbuil (grep, remove, build), i.e. manually cleaning up
includes and forward declarations which are not needed

Done by primitive grepping for Q/K* class names and

  • removing any includes whose class does not have instances by a quick look in implementations in the same file
  • using forward declarations instead of includes for classes whe possible, unless a template class (because the latter is quite verbose as forward declarations, the include nicer to read)
  • removing any forward declarations which are not used in the same file

(one day a bot/script will steal my game and beat me, o tempores)

WRT effects on dependent code, at least kdevelop will need one or
two adaptions due to changed include visibility. That is done as
part of a similar clean-up patch, which will be either directly
pushed or also passed through review, as you prefer.

Diff Detail

Repository
R33 KDevPlatform
Branch
includeSpringCleaning
Lint
No Linters Available
Unit
No Unit Test Coverage
kossebau created this revision.Mar 16 2017, 5:45 PM
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptMar 16 2017, 5:45 PM
apol accepted this revision.Mar 16 2017, 6:23 PM
apol added a subscriber: apol.

One day we won't have to include each and every class separately... :P

Good stuff! :)

This revision is now accepted and ready to land.Mar 16 2017, 6:23 PM
kfunk closed this revision.Mar 17 2017, 6:56 PM
kfunk added a subscriber: kfunk.

Has been pushed: ec809d58e91a4060d9c4bb3d2142ca29be95d8b5