Port to KStandardAction::DeleteFile
ClosedPublic
Actions

Authored by elvisangelaccio on Mar 10 2017, 6:48 PM.

Details

Reviewers

Commits

R318:68bb0ec22af0: Port to KStandardAction::DeleteFile

Summary

It was introduced in kconfig 5.25 and it properly handles the shift+del
shortcut (together with kxmlgui >= 5.30). This allows us to drop the
custom delete shortcut as well as the shift+del workaround in
DolphinMainWindow.

Test Plan

Shift+Del still deletes files, without the 'ambiguous shortcut' warning dialog.

Diff Detail

Repository

R318 Dolphin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

elvisangelaccio created this revision.Mar 10 2017, 6:48 PM

emmanuelp accepted this revision.Mar 13 2017, 3:20 PM

This revision is now accepted and ready to land.Mar 13 2017, 3:20 PM

Closed by commit R318:68bb0ec22af0: Port to KStandardAction::DeleteFile (authored by elvisangelaccio). · Explain WhyMar 13 2017, 6:50 PM

This revision was automatically updated to reflect the committed changes.

elvisangelaccio mentioned this in T5032: Stop manually removing shift+del shortcut.Apr 27 2017, 9:56 AM

Revision Contents
Changeset List

			Path	Packages
M			src/dolphincontextmenu.cpp (6 lines)
M			src/dolphinmainwindow.cpp (10 lines)
M			src/dolphinpart.cpp (6 lines)
M			src/dolphinremoveaction.h (4 lines)
M			src/dolphinremoveaction.cpp (2 lines)
M			src/views/dolphinviewactionhandler.cpp (8 lines)