Differential D4930

Add basic support for parsing OpenCL
ClosedPublic
Actions

Authored by kfunk on Mar 4 2017, 12:47 AM.

Details

Reviewers

mwolff

Group Reviewers

KDevelop

Commits

R32:da4e1a0f23a0: Add basic support for parsing OpenCL

Summary

Diff Detail

Repository

R32 KDevelop

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

kfunk created this revision.Mar 4 2017, 12:47 AM

Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptMar 4 2017, 12:47 AM

Note: There's no such thing as OpenCL mime type in shared-mime-info yet.

Proposed a patch upstream: https://bugs.freedesktop.org/show_bug.cgi?id=99654

Coding style fixes

Bump?

I'd actually like to get this into 5.1 branch so we have the OpenCL support as part of the 5.1.0 release. This patch is super trivial and doesn't change any existing behavior (e.g. in the C/C++/ObjC support parts).

LGTM but I know nothing about neither clang nor opencl :/

nice!

languages/plugins/custom-definesandincludes/compilerprovider/settingsmanager.cpp
85	keep the `{` on the next line please, or at least add a whitespace in front

This revision is now accepted and ready to land.Mar 5 2017, 7:26 PM

Closed by commit R32:da4e1a0f23a0: Add basic support for parsing OpenCL (authored by kfunk). · Explain WhyMar 6 2017, 8:31 AM

This revision was automatically updated to reflect the committed changes.

qi437103 mentioned this in D5072: Add basic support for CUDA parsing.Mar 16 2017, 7:11 PM

qi437103 mentioned this in R32:64d7d49ed3a2: Add basic support for CUDA parsing.Mar 17 2017, 7:33 PM

Revision Contents
Changeset List

		Path
M		languages/clang/duchain/parsesession.cpp (6 lines)
M		languages/clang/kdevclangsupport.json (2 lines)
A	M	languages/clang/tests/files/test.cl (15 lines)
M		languages/clang/tests/test_files.cpp (2 lines)
M		languages/plugins/custom-definesandincludes/compilerprovider/settingsmanager.h (12 lines)
M		languages/plugins/custom-definesandincludes/compilerprovider/settingsmanager.cpp (10 lines)
M		languages/plugins/custom-definesandincludes/definesandincludesmanager.cpp (26 lines)
M		languages/plugins/custom-definesandincludes/kcm_widget/parserwidget.cpp (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	12150	1953859		Mar 4 2017, 12:47 AM	★	★
Diff 2	12151	1953859	Coding style fixes	Mar 4 2017, 12:50 AM	★	★
Diff 3	12226	696d3e5	R32:da4e1a0f23a061feb88dc49bc085aad713551377	Mar 6 2017, 8:31 AM	★	★