[Menu] Harmonize openRelative placement
ClosedPublic

Authored by romangg on Mar 3 2017, 1:57 PM.

Details

Summary

With D4867 the placement was already changed a bit, but mostly the correction if there is not enough screen space available. This new patch is meant to harmonize the placement for the available enums in a sensible way.

Instead of much talking take a look at the placement prior to D4867:

Currently / with D4867:

With this patch:

Regarding the enum names in the API and the normal use cases of a menu I think this last pattern makes the most sense. In this case the correctional behavior on screen space limits could get simplified as well. This would become a separate patch though.

Test Plan

Tested with plasma-pa and task manager context menu.

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
romangg created this revision.Mar 3 2017, 1:57 PM
Restricted Application added a subscriber: Frameworks. · View Herald TranscriptMar 3 2017, 1:57 PM
hein accepted this revision.Mar 21 2017, 12:38 PM
This revision is now accepted and ready to land.Mar 21 2017, 12:38 PM
This revision was automatically updated to reflect the committed changes.