Fix crash in chart, add a deleable flag to KoShape
ClosedPublic

Authored by danders on Mar 2 2017, 8:16 AM.

Details

Summary

Problem is that ChartShape does not handle deleted components,
but it shall be possible to manipulate these components.

This patch adds a deletable flag to KoShape and checks this flag
in the default tool before trying to delete a shape.
ChartShape then sets this falg for all its components.

Currently isGeometryProtected() is used to block deletion of a shape.
This behavior is not changed atm.
Imo this should be reviewed so that geometry can be protected also for deletable shapes.

Diff Detail

Repository
R8 Calligra
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
danders created this revision.Mar 2 2017, 8:16 AM
Restricted Application added a project: Calligra: 3.0. · View Herald TranscriptMar 2 2017, 8:16 AM
anthonyfieroni edited edge metadata.Mar 5 2017, 7:26 AM

Looks good to me.

This revision was automatically updated to reflect the committed changes.