[ConfigCategory] Deduce name and icon from pluginName
AcceptedPublic

Authored by broulik on Mar 1 2017, 1:35 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Summary

This way one can just add a KCM as-is without having to worry about a potentially diverging translation or icon from System Settings.

Test Plan

Placed the following in plasma-pa's config.qml

ConfigCategory {
    pluginName: "kcms/kcm_pulseaudio"
}

Even though I didn't specify an icon or name, it showed up.


Added a plugin which doesn't exist, printed a warning and didn't show up.

It seems weird that I have to add "kcms/" prefix to it in contrast to X-Plasma-ConfigPlugins though, and I also didn't find anyone actually using pluginName. Also lacks a KIOSK check because of the kcms/ prefix.

Maybe we should support both? We can't change force it, though, as it will be a behavior change.

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Mar 1 2017, 1:35 PM
Restricted Application added projects: Plasma, Frameworks. · View Herald TranscriptMar 1 2017, 1:35 PM
Restricted Application added subscribers: Frameworks, plasma-devel. · View Herald Transcript
davidedmundson accepted this revision.Aug 19 2017, 2:59 PM
This revision is now accepted and ready to land.Aug 19 2017, 2:59 PM