Make the hover state optional.
ClosedPublic

Authored by hein on Feb 27 2017, 11:36 AM.

Details

Summary

This is desired by a downstream distro which doesn't want hover
effects in Folder View, but can't remove the graphics from the
theme without negatively impacting other UI.

It should go into the 5.9 branch to allow them to ship 5.9.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
hein created this revision.Feb 27 2017, 11:36 AM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 27 2017, 11:36 AM
markg added a subscriber: markg.Feb 27 2017, 11:47 AM

I really doubt the usefulness in supporting this "feature".
It smalls like something one distribution apparently wants, but the vast majority is fine with having the hover effect there. In fact, they might even consider it a bug - i would - if it doesn't change on hover.

I think such a minor setting as this should not be supported. It should rather be the task of that distribution to change plasma-desktop to their (more than usual) custom needs.

Just my opinion :)

mart accepted this revision.Feb 27 2017, 11:53 AM
This revision is now accepted and ready to land.Feb 27 2017, 11:53 AM
hein added a comment.Feb 27 2017, 11:54 AM

@Mark: I respect that point of view, but there's also some value to reducing the patch delta between us and downstreams. I sometimes see distributons write (and rewrite, and rewrite, and rewrite) and carry patches to do things like this for years, and they sometimes get it pretty wrong and break other things inadvertently, which then impacts our quality rep. If it's upstream at least it's reviewed code.

This revision was automatically updated to reflect the committed changes.