Extract a single file from a QString which contains the generated
content.
The usage of this function by kio_help reduces the number of the
functions from xslt.* used by KIO.
Details
Details
- Reviewers
dfaure - Commits
- R238:be23cd457327: Add function to extract a single file
Compiles, no functional changes (tested with a dependent change in KIO).
Diff Detail
Diff Detail
- Repository
- R238 KDocTools
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
The code looks ok, I'm just not sure this is "nice" exported API though. ("do", no documentation, ...)
Comment Actions
Looks good, just some nitpicks. Feel free to push directly.
src/xslt.cpp | ||
---|---|---|
365 ↗ | (On Diff #11873) | QLatin1String would be better (because it's a comparison, and there's a QLatin1String overload for this purpose) |
368 ↗ | (On Diff #11873) | I like the value added by the comment :-) |
src/xslt.h | ||
17 ↗ | (On Diff #11873) | I think doxygen needs /** here, no? |