Differential D4778

Add include that is needed in msys2
ClosedPublic
Actions

Authored by russellg on Feb 25 2017, 12:44 AM.

Details

Reviewers
kfunk
Group Reviewers
Frameworks
Commits
R245:21118a62b546: Add include that is needed in msys2
Summary

In the latest msys2, they updated some windows headers to require this extra include. It's not specific to this project, openFrameworks had to do it as well.

Test Plan

None, it just fixes a build. If I could get some guidance I would be willing to try to get a CI build for it.

Diff Detail

Repository
R245 Solid
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
russellg created this revision.Feb 25 2017, 12:44 AM
kfunk accepted this revision.Feb 26 2017, 6:03 AM
This revision is now accepted and ready to land.Feb 26 2017, 6:03 AM
russellg added a comment.Apr 3 2017, 11:43 PM

So where does this go now?

Sorry I've never submitted a patch in phabricator before :P

Am I supposed to merge this, or is somebody else?

kfunk added a comment.Apr 4 2017, 7:39 AM

I've pushed your patch now. Usually the author is responsible for pushing, as long as he has commit access to our infrastructure ;)

Closed by commit R245:21118a62b546: Add include that is needed in msys2 (authored by kfunk). · Explain WhyApr 4 2017, 7:44 AM
This revision was automatically updated to reflect the committed changes.
russellg added a comment.Apr 4 2017, 2:51 PM

Alright, I will in the future :)

Revision Contents
Changeset List

Diff 13083

View Options

src/solid/devices/backends/win/winbattery.cpp

Loading...