Port to categorized logging and clean includes
ClosedPublic

Authored by ltoscano on Feb 23 2017, 12:53 AM.

Details

Summary

Convert all occurrencies of q{Debug,Warning,Critical,...},
including the calls commented.
Cleanup for non-required includes of QDebug, and few extra comments.

Recommitted after the revert now that KDocTools exports a proper
shared library (the initial patch broke KIO, as the KDocToolsLog
symbol was not found when KIO linked to the static library
previously exported).

Test Plan

Compiles and KIO compiles too.

Diff Detail

Repository
R238 KDocTools
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
ltoscano created this revision.Feb 23 2017, 12:53 AM
Restricted Application added projects: Frameworks, Documentation. · View Herald TranscriptFeb 23 2017, 12:53 AM
Restricted Application added subscribers: Documentation, Frameworks. · View Herald Transcript
kfunk accepted this revision.Feb 24 2017, 7:29 AM
This revision is now accepted and ready to land.Feb 24 2017, 7:29 AM
This revision was automatically updated to reflect the committed changes.
ltoscano reopened this revision.Mar 3 2017, 5:11 PM

I had to revert this because it broke KIO, as KDocTools exported only a static library. This forced me to finally implement a dynamic library, so now I can try to propose a new proper revision.

This revision is now accepted and ready to land.Mar 3 2017, 5:11 PM
ltoscano updated this revision to Diff 12139.Mar 3 2017, 5:12 PM

Recommitted after the revert now that KDocTools exports a proper
shared library (the initial patch broke KIO).

ltoscano edited the summary of this revision. (Show Details)Mar 3 2017, 5:14 PM
ltoscano edited the test plan for this revision. (Show Details)
This revision was automatically updated to reflect the committed changes.