Fix disabling the spinner animation when Busy indicator has no opacity
ClosedPublic

Authored by davidedmundson on Feb 22 2017, 11:38 PM.

Details

Summary

Unlike the visible property, the opacity does not inherit parent values
and refers to the relative opacity of that item.

The current style code is checking that an item we can't control
externally has an opacity > 0, this doesn't really acheive anything.

This was a breakage from when we ported *to* QtQuickControls 1.

Test Plan

I was running a plasmoid I had written years ago (my RSS tutorial)
and had abnormally high CPU usage in an animation that I didn't have then.

Code was:

BusyIndicator {
opacity: 0
running: true
}

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added projects: Plasma, Frameworks. · View Herald TranscriptFeb 22 2017, 11:38 PM
Restricted Application added subscribers: Frameworks, plasma-devel. · View Herald Transcript
mart accepted this revision.Feb 23 2017, 10:26 AM
This revision is now accepted and ready to land.Feb 23 2017, 10:26 AM
This revision was automatically updated to reflect the committed changes.