[KCM] Show notification stream at end of list
Needs ReviewPublic

Authored by romangg on Feb 22 2017, 6:20 PM.

Details

Reviewers
drosca
Group Reviewers
VDG
Plasma
Summary

The notification stream is not as important to the user than other app streams. Show it therefore at the end of the list.

Rearranging the separator also fixes a small spacing issue with the first item always being smaller in vertical size than the other ones.

master:

patched:

Diff Detail

Repository
R115 Plasma Audio Volume Applet
Lint
Lint Skipped
Unit
Unit Tests Skipped
romangg created this revision.Feb 22 2017, 6:20 PM
Restricted Application added a subscriber: plasma-devel. ยท View Herald TranscriptFeb 22 2017, 6:20 PM
romangg edited the summary of this revision. (Show Details)Feb 22 2017, 6:22 PM
drosca edited edge metadata.Feb 22 2017, 6:47 PM

There is a reason it is on top. This KCM is UI-wise just copy of pavucontrol, and that's the way it is done in pavucontrol. Also this stream is special, because it is always present. I would myself prefer to leave it on top, but I will follow the decision made by VDG.

I don't really see the issue about size from your screenshots.

drosca added a reviewer: VDG.Feb 22 2017, 6:48 PM

Thanks. Didn't know about the design similarity to pavucontrol. But in this case it doesn't make much sense to me how pavucontrol is handling this. Something which is always there and is only for system internals, doesn't need to be presented at top position. What I want to see at the top are my applications, which play my music or whatever.

Regarding the size: When you look at the separator lines in the following screenshot, you can see that the spacing between the top and the first one is smaller than the one between the first and the second one (ca. 105px vs 120px)

Regarding the size: When you look at the separator lines in the following screenshot, you can see that the spacing between the top and the first one is smaller than the one between the first and the second one (ca. 105px vs 120px)

I can see what you mean now, thanks. But this needs to go in separate commit.

In D4724#88718, @drosca wrote:

Regarding the size: When you look at the separator lines in the following screenshot, you can see that the spacing between the top and the first one is smaller than the one between the first and the second one (ca. 105px vs 120px)

I can see what you mean now, thanks. But this needs to go in separate commit.

Not possible. Otherwise the line is not between the two items but below the Notification stream (in the diff I only moved the line to the top of a ListView item). What could be changed though in a separate commit is the alignment of the line. Before it was too near to the item above it. Now it is too near to the item below it.