Differential D4702

IconItemTest: Fix loadPixmap and loadImage tests
ClosedPublic
Actions

Authored by drosca on Feb 21 2017, 11:02 AM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R242:148ff6311bfe: IconItemTest: Fix loadPixmap and loadImage tests
Summary

It only works on CI because data/test_image.png size
is the same as implicitSize of IconItem (KIconLoader::Dialog).

Test Plan

Test pass locally (KIconLoader::Dialog == 64)

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
drosca created this revision.Feb 21 2017, 11:02 AM
Restricted Application added projects: Plasma, Frameworks. · View Herald TranscriptFeb 21 2017, 11:02 AM
Restricted Application added subscribers: Frameworks, plasma-devel. · View Herald Transcript
davidedmundson accepted this revision.Feb 21 2017, 11:03 AM
This revision is now accepted and ready to land.Feb 21 2017, 11:03 AM
Closed by commit R242:148ff6311bfe: IconItemTest: Fix loadPixmap and loadImage tests (authored by drosca). · Explain WhyFeb 21 2017, 11:05 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mautotests/iconitemtest.cpp (2 lines)

Diff 11583

View Options

autotests/iconitemtest.cpp

Loading...