if there is no battery don't show 0%, but a - on
the badge. still show the badge to show the option is not broken,
but don't show a weird 0% of a non existing battery
Details
Details
- Reviewers
davidedmundson - Group Reviewers
Plasma - Commits
- R120:9131740a82f8: don't show 0% when no battery
works on both systems with or without battery
Diff Detail
Diff Detail
- Repository
- R120 Plasma Workspace
- Branch
- arcpatch-D4606
- Lint
No Linters Available - Unit
No Unit Test Coverage
| applets/batterymonitor/package/contents/ui/BadgeOverlay.qml | ||
|---|---|---|
| 36 ↗ | (On Diff #11328) | what's this for? |
| applets/batterymonitor/package/contents/ui/CompactRepresentation.qml | ||
|---|---|---|
| 74 ↗ | (On Diff #11328) | Please use a – instead of a - and perhaps i18nc so it can be translated to another special character if needed |
Comment Actions
Does it even make sense to show this thing if there's no battery? We already show a cross on the icon then, don't we? Makes it a bit redundant. On the other hand it could be confusing to have the option checked but then have it not do anything – maybe the check box needs to be grayed out in case there's no battery.
Comment Actions
the idea was to stilòl have the badge show up to not make that option look "broken". tough also having the checkbox greyed out makes sense too
| applets/batterymonitor/package/contents/ui/BadgeOverlay.qml | ||
|---|---|---|
| 36 ↗ | (On Diff #11328) | to keep it large enough to keep it looking good |
Comment Actions
ah, found another reason why keeping the badge would be desiderable: laptops with removable battery (yeah, some of them are still out there :p) would make the option basically unconfigurable until you can attach a battery again to it.