Differential D4558

Fail the build early if xmllint is not available
ClosedPublic
Actions

Authored by ltoscano on Feb 10 2017, 10:57 PM.

Details

Reviewers
winterz
Commits
R238:d7e0d20ae5f6: Fail the build early if xmllint is not available
Summary

xmllint is required later anyway, and kio_help has the check.
BUG: 376246

Test Plan

If xmllint is not available, compilation fails in the cmake phase.

Diff Detail

Repository
R238 KDocTools
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ltoscano updated this revision to Diff 11197.Feb 10 2017, 10:57 PM
ltoscano retitled this revision from to Fail the build early if xmllint is not available.
ltoscano updated this object.
ltoscano edited the test plan for this revision. (Show Details)
Restricted Application added projects: Frameworks, Documentation. · View Herald TranscriptFeb 10 2017, 10:57 PM
Restricted Application added subscribers: Documentation, Frameworks. · View Herald Transcript
winterz edited edge metadata.Feb 11 2017, 1:32 PM

guess this is the best you can do given that FindLibXml2 sets LibXml2_FOUND even if xmllint is not found.

ltoscano added a comment.Feb 11 2017, 1:38 PM

I would say that the LibXML2 behaviour is correct. This "if" is what kio does as well, the same code was in kdelibs4/kdoctools but it was lost here in the split.

(if you approve the change, please remember to select the specific action for it)

winterz accepted this revision.Feb 11 2017, 2:06 PM
winterz edited edge metadata.

ok

This revision is now accepted and ready to land.Feb 11 2017, 2:06 PM
Closed by commit R238:d7e0d20ae5f6: Fail the build early if xmllint is not available (authored by ltoscano). · Explain WhyFeb 11 2017, 2:40 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (3 lines)

Diff 11222

View Options

CMakeLists.txt

Loading...