Ref/deref DataEngines even if the metadata is invalid
ClosedPublic

Authored by davidedmundson on Feb 10 2017, 9:58 PM.

Details

Summary

Just because the metadata is invalid doesn't mean the DataEngine
actually failed to load, we're still returning a valid object, and as
seen with the MPris DataEngine bug. It's important that we still release
it properly.

It looks like this was designed to make sure you don't delete the null
data engine multiple times, but that shouldn't cause an issue here.

Test Plan

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson retitled this revision from to Ref/deref DataEngines even if the metadata is invalid.
davidedmundson updated this object.
davidedmundson edited the test plan for this revision. (Show Details)
davidedmundson added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks. · View Herald TranscriptFeb 10 2017, 9:58 PM
Restricted Application added subscribers: Frameworks, plasma-devel. · View Herald Transcript
mart accepted this revision.Feb 22 2017, 4:19 PM
This revision is now accepted and ready to land.Feb 22 2017, 4:19 PM
This revision was automatically updated to reflect the committed changes.