Differential D4549

GDB Memory viewer: port MemoryRangeSelector to QFormLayout/QDialogButtonBox
ClosedPublic
Actions

Authored by kossebau on Feb 10 2017, 1:13 PM.

Details

Reviewers
apol
volden
Group Reviewers
KDevelop
Commits
R32:5d04550a3eff: GDB Memory viewer: port MemoryRangeSelector to QFormLayout/QDialogButtonBox
Summary

Using QFormLayout & QDialogButtonBox results in less code and
UI following automatically more closer to platform settings,
like order of Ok/Cancel buttons, icons on buttons, text on buttons,
alignment of labels in form.

Diff Detail

Repository
R32 KDevelop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau updated this revision to Diff 11174.Feb 10 2017, 1:13 PM
kossebau retitled this revision from to GDB Memory viewer: port MemoryRangeSelector to QFormLayout/QDialogButtonBox.
kossebau updated this object.
kossebau added reviewers: KDevelop, volden.
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptFeb 10 2017, 1:13 PM
kossebau added a comment.Feb 10 2017, 1:16 PM

Before:

After:

apol accepted this revision.Feb 10 2017, 11:01 PM
apol added a reviewer: apol.
apol added a subscriber: apol.

Good!
This tab thing looks weird, is it a standard component? :S

This revision is now accepted and ready to land.Feb 10 2017, 11:01 PM
Closed by commit R32:5d04550a3eff: GDB Memory viewer: port MemoryRangeSelector to QFormLayout/QDialogButtonBox (authored by kossebau). · Explain WhyFeb 11 2017, 1:01 AM
This revision was automatically updated to reflect the committed changes.
kossebau added a comment.Feb 11 2017, 1:07 AM
In D4549#85193, @apol wrote:

Good!
This tab thing looks weird, is it a standard component? :S

It is a QToolBox. Also raised my eyebrows, but leaving any change here to professional users of that tool :)

Thanks for review!

Revision Contents
Changeset List

PathPackages
Mdebuggers/gdb/memviewdlg.cpp (41 lines)

Diff 11199

View Options

debuggers/gdb/memviewdlg.cpp

Loading...