Differential D4530

WIP: Don't re-show auto-hidden client on geometry change if they're still at a screen edge
AbandonedPublic
Actions

Authored by broulik on Feb 9 2017, 4:02 PM.

Details

Reviewers
None
Group Reviewers
Plasma
KWin
Summary

When you have an applet whose size changes (e.g. global menu) it will cause the panel to re-show.

BUG: 376239

Test Plan

TODO:

  • Wayland
  • Unittests

(Patch to see whether I'm at least somewhat on the right track with this)

Put a panel at the bottom (and top), added global menu, centered the panel, switched between different windows, panel didn't re-show but was still accessible by touching the screen edge with my mouse

Diff Detail

Repository
R131 Plasma Wallpapers
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik updated this revision to Diff 11119.Feb 9 2017, 4:02 PM
broulik retitled this revision from to WIP: Don't re-show auto-hidden client on geometry change if they're still at a screen edge.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added reviewers: Plasma, KWin.
broulik set the repository for this revision to R131 Plasma Wallpapers.
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 9 2017, 4:02 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik changed the repository for this revision from R131 Plasma Wallpapers to R108 KWin.Feb 10 2017, 9:58 AM
graesslin added a subscriber: graesslin.Feb 10 2017, 9:59 AM

We do have autotests for this in autotests/integration/screenedge_client_show_test.cpp

graesslin added inline comments.Feb 10 2017, 10:03 AM
client.cpp
2086–2094

I think we need to have some more checks here. Like only left if it's also the left most screen.

broulik abandoned this revision.Mar 8 2017, 3:52 PM

Superseded by D4718

Revision Contents
Changeset List

PathPackages
Mclient.cpp (32 lines)

Diff 11119

View Options

client.cpp

Loading...