File templates dialog: Fix crash in overrides page with unknown base class
ClosedPublic
Actions

Authored by kossebau on Feb 9 2017, 2:57 PM.

Details

Reviewers

Group Reviewers

Commits

Summary

Having entered a base class which is unknown to the DUChain,
on preparing the page with overrides KDevelop crashes.

This is fixed by catching the case that there is no
context available for a base class.

Repository

R33 KDevPlatform

Branch

fixCrashInFileTemplateDialogOnUnknownBaseClass

Lint

No Linters Available

Unit

No Unit Test Coverage

kossebau retitled this revision from to File templates dialog: Fix crash in overrides page with unknown base class.

kossebau updated this object.

kossebau added a reviewer: KDevelop.

Target: 5.0 (if there is a 5.0.5 planned)

Change to declaration.h will be a separate commit.

lgtm

This revision is now accepted and ready to land.Feb 9 2017, 7:50 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			language/duchain/declaration.h (2 lines)
M			plugins/filetemplates/overridespage.cpp (7 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	11114	b6f146f		Feb 9 2017, 2:57 PM	★	★
Diff 2	11134	87de15b	R33:f01e4cba08e2a2bec6500df9aa24b7aad8b0ca59	Feb 9 2017, 8:51 PM	★	★