Originally posted as https://git.reviewboard.kde.org/r/127034 but adjusted to check whether the tab we released the mouse button on is actually the one where we depressed it.
Details
Details
- Reviewers
emmanuelp - Group Reviewers
Dolphin - Commits
- R318:f7770c60b171: Close tab on mouse release rather than on mouse press
Diff Detail
Diff Detail
- Repository
- R318 Dolphin
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Thanks for the adjustments, looks good!
Not related to this particular review request:
IMHO it would be better to update the *existing* reviews on RR rather than closing them and upload the new patches somewhere else. But given that you have already updated all of your patches: Can you please add the differential links to the corresponding RR review requests? Thanks! :)
Comment Actions
I did that because Review Board is being phased out and we were asked to abandon and/or push and/or migrate to Phabricator any remaining patches.