Don't use KConfig keys with backslashes
ClosedPublic

Authored by elvisangelaccio on Feb 8 2017, 11:43 AM.

Details

Summary

Kile has ambiguous shortcuts which result in the following string used
as KConfig key for the dontShowAgain KMessageBox checkbox:

Find in Files...Normal Fraction - \frac{}{}Alt+Shift+F

However KConfig doesn't like it:

"Invalid escape sequence \"\\f\"."

and the 'f' character after the slash is removed from the key, breaking the
dontShowAgain functionality.

This patch removes all backslashes from the key, before passing it to
the messagebox.

Test Plan

Open Kile, check the dontShowAgain checkbox, close Kile. Open again Kile and
make sure the messagebox is not shown again.

Diff Detail

Repository
R263 KXmlGui
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
elvisangelaccio retitled this revision from to Don't use KConfig keys with backslashes.
elvisangelaccio updated this object.
elvisangelaccio edited the test plan for this revision. (Show Details)
elvisangelaccio added a reviewer: aacid.
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 8 2017, 11:43 AM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
aacid accepted this revision.Feb 8 2017, 7:27 PM
aacid edited edge metadata.

It's probably better to actually fix kile ;)

But ok.

This revision is now accepted and ready to land.Feb 8 2017, 7:27 PM
In D4496#84368, @aacid wrote:

It's probably better to actually fix kile ;)

But ok.

I agree, even though if I press Alt+Shift+F in Kile I don't get the warning dialog, so I suppose the two actions are not enabled at the same time.

This revision was automatically updated to reflect the committed changes.