Support creation of PlasmaShellSurface prior to ShellSurface
ClosedPublic

Authored by graesslin on Feb 7 2017, 6:26 PM.

Details

Summary

So far KWin did not support the sequence:

  1. Create wl_shell
  2. Create PlasmaShellSurface
  3. Create wl_shell_surface

KWin only supported the case that the PlasmaShellSurface is the last
thing to get created. This is rather limiting and can be considered a
bug. At least we had a QEXPECT_FAIL auto test for this situation. So
it was a known issue.

This change should make it easier to support the QtWayland changes in
Qt 5.8.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin updated this revision to Diff 11022.Feb 7 2017, 6:26 PM
graesslin retitled this revision from to Support creation of PlasmaShellSurface prior to ShellSurface.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
graesslin added reviewers: KWin, Plasma on Wayland.
Restricted Application added projects: Plasma on Wayland, KWin. · View Herald TranscriptFeb 7 2017, 6:26 PM
Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript
mart added a subscriber: mart.Feb 7 2017, 7:45 PM

with this on top of https://codereview.qt-project.org/#/c/184278/ the situation with Qt 5.8 is definitely improved

davidedmundson accepted this revision.Feb 7 2017, 8:54 PM
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.Feb 7 2017, 8:54 PM
This revision was automatically updated to reflect the committed changes.