Reverse TaskManager DragDrop to blacklist Plasma instead of whitelisting URLs
ClosedPublic

Authored by davidedmundson on Feb 7 2017, 1:12 PM.

Details

Summary

A previous patch made the task manager only accept drag events which
contained URL lists or internal taskmanager mimedata in order to make it
easier to drag applets onto the panel.

This broke a feature where you can drag arbitrary mimedata between
windows and hovering above a task will raise that window.

This patch reverses the logic to only ignore plasmoids, and accept all
other drag/drops.

BUG: 375871
FIXED-IN: 5.9.2

Test Plan

Dragged applet from Widget explorer onto task manager and the task manager moved to
the side to allow a drop.

set sorting to manual and moved a task

Dragged some text onto a task, and that window raised immediately

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson retitled this revision from to Reverse TaskManager DragDrop to blacklist Plasma instead of whitelisting URLs.
davidedmundson updated this object.
davidedmundson edited the test plan for this revision. (Show Details)
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 7 2017, 1:12 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik added a subscriber: broulik.Feb 7 2017, 2:04 PM
broulik added inline comments.
applets/taskmanager/package/contents/ui/MouseHandler.qml
134

For onDrop the URL check is fine. There we would launch the respective application and send the URL to it

davidedmundson abandoned this revision.Feb 7 2017, 2:40 PM

Fix stupid phab getting itself confused

Trying again to make phab show the same thing

broulik added inline comments.Feb 7 2017, 2:47 PM
applets/taskmanager/package/contents/ui/MouseHandler.qml
134

Nevermind. You did the right thing, and I was already wondering why my comment showed up on the left column in Phab :D

+1

applets/taskmanager/package/contents/ui/MouseHandler.qml
123–124
// Reject plasmoid drops, so the containment can handle them.
hein accepted this revision.Feb 7 2017, 3:18 PM
hein added a reviewer: hein.
This revision is now accepted and ready to land.Feb 7 2017, 3:18 PM
This revision was automatically updated to reflect the committed changes.