Differential D4471

Fix KCModule::setAuthAction error checking
ClosedPublic
Actions

Authored by davidedmundson on Feb 7 2017, 9:04 AM.

Details

Reviewers
mart
Group Reviewers
Plasma
Commits
R265:49dbf1beaff2: Fix KCModule::setAuthAction error checking
Summary

The current code checks if the existing action is valid rather the
argument; and if it is invalid does an early return. That means you
can't ever properly set a valid action.

Test Plan

Started clock KCM which uses this, confirmed we got no warning

Diff Detail

Repository
R265 KConfigWidgets
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson updated this revision to Diff 10991.Feb 7 2017, 9:04 AM
davidedmundson retitled this revision from to Fix KCModule::setAuthAction error checking.
davidedmundson updated this object.
davidedmundson edited the test plan for this revision. (Show Details)
davidedmundson added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks. · View Herald TranscriptFeb 7 2017, 9:04 AM
Restricted Application added subscribers: Frameworks, plasma-devel. · View Herald Transcript
mart accepted this revision.Feb 7 2017, 9:23 AM
mart added a reviewer: mart.
This revision is now accepted and ready to land.Feb 7 2017, 9:23 AM
Closed by commit R265:49dbf1beaff2: Fix KCModule::setAuthAction error checking (authored by davidedmundson). · Explain WhyFeb 10 2017, 1:01 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/kcmodule.cpp (2 lines)

Diff 11172

View Options

src/kcmodule.cpp

Loading...