Port auto-encryption in KMail's composer to Trust Levels
Needs ReviewPublic

Authored by dvratil on Feb 6 2017, 3:35 PM.

Details

Summary

This changes the auto-encryption code in KMail's composer to use the Trust Levels (from Kleo::trustLevel()) and adjusts the description strings accordingly.

The code works, but I'm really unsure about those strings. I'm not sure if they are actually helping or if they would just be confusing to users. Any feedback is welcomed :)

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
dvratil updated this revision to Diff 10969.Feb 6 2017, 3:35 PM
dvratil retitled this revision from to Port auto-encryption in KMail's composer to Trust Levels.
dvratil updated this object.
dvratil edited the test plan for this revision. (Show Details)
dvratil added reviewers: aheinecke, bjoernbalazs.
dvratil set the repository for this revision to R206 KMail.
dvratil added a project: KDE PIM: KMail.
dvratil added a subscriber: KDE PIM: KMail.
Restricted Application added a project: KDE PIM. · View Herald TranscriptFeb 6 2017, 3:35 PM
Restricted Application added a subscriber: KDE PIM. · View Herald Transcript
knauss added a subscriber: knauss.Feb 7 2017, 6:11 PM
knauss added inline comments.
src/editor/kmcomposerwin.cpp
3420

Level0 is also true when the key was nevr used to write encrypted. Well normally you want to start writing encrypted if there is a key, so you also need to detect this case.

3425

[...] and hansn't used often enough to garantee that it belongs to the stated person.

3430

[...], but the key was used several times succellfully, so it is very likely, that the key is controlled by the stated person.

dvratil updated this revision to Diff 12426.Mar 13 2017, 10:31 AM

Use the new gpg-key-trust-level icons.