Differential D4449

Port tooltips to KToolTipWidget
ClosedPublic
Actions

Authored by elvisangelaccio on Feb 5 2017, 6:05 PM.

Details

Reviewers

emmanuelp

Maniphest Tasks

T4980: Port tooltips to KToolTipWidget

Commits

R318:230fe13d1fcc: Port tooltips to KToolTipWidget

Summary

Use the new KToolTipWidget class (introduced by kwidgetsaddons 5.30) as backend of ToolTipManager.
FileMetaDataToolTip becomes a simple widget used as content of the tooltip.

It is now possible to actually use the metadata widget shown inside the tooltips.
Tooltips are now functional on Wayland, as well.

More information about KToolTipWidget in https://git.reviewboard.kde.org/r/129648/

BUG: 352276
BUG: 371223
FIXED-IN: 17.04.0

Test Plan

Tooltips work as expected in Plasma wayland session.
Mouse cursor can now enter the tooltip and use the metadata widget
Tooltips are still correctly positioned in multi-screen setups
Big tooltips are still correctly positioned when the item/mouse is near a screen edge

Diff Detail

Repository

R318 Dolphin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

elvisangelaccio updated this revision to Diff 10943.Feb 5 2017, 6:05 PM

elvisangelaccio retitled this revision from to Port tooltips to KToolTipWidget.

elvisangelaccio updated this object.

elvisangelaccio edited the test plan for this revision. (Show Details)

elvisangelaccio added a reviewer: emmanuelp.

elvisangelaccio set the repository for this revision to R318 Dolphin.

elvisangelaccio updated this revision to Diff 10944.Feb 5 2017, 6:08 PM

elvisangelaccio edited the test plan for this revision. (Show Details)Feb 5 2017, 6:11 PM

elvisangelaccio added a task: T4980: Port tooltips to KToolTipWidget.

elvisangelaccio updated this object.

elvisangelaccio added a project: Dolphin.

Nice, thanks!

This revision is now accepted and ready to land.Feb 5 2017, 7:47 PM

Closed by commit R318:230fe13d1fcc: Port tooltips to KToolTipWidget (authored by elvisangelaccio). · Explain WhyFeb 5 2017, 10:04 PM

This revision was automatically updated to reflect the committed changes.

elvisangelaccio mentioned this in R318:230fe13d1fcc: Port tooltips to KToolTipWidget.

Revision Contents
Changeset List

			Path	Packages
M			CMakeLists.txt (2 lines)
M			src/views/dolphinview.cpp (2 lines)
M			src/views/tooltips/filemetadatatooltip.h (8 lines)
M			src/views/tooltips/filemetadatatooltip.cpp (19 lines)
M			src/views/tooltips/tooltipmanager.h (10 lines)
M			src/views/tooltips/tooltipmanager.cpp (84 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	10943			Feb 5 2017, 5:45 PM	★	★
Diff 2	10944			Feb 5 2017, 6:08 PM	★	★
Diff 3	10946	6fc68fe	R318:230fe13d1fccf8c2ab09c0873c1cc4c733cfc3b4	Feb 5 2017, 9:56 PM	★	★