Differential D4436

[Button Styles] Use Layout.fillHeight instead of parent.height in a Layout
ClosedPublic
Actions

Authored by broulik on Feb 4 2017, 9:52 PM.

Details

Reviewers
mart
Group Reviewers
Plasma
Commits
R242:c21ff749e646: [Button Styles] Use Layout.fillHeight instead of parent.height in a Layout
Summary

This fixes the label not being vertically centered if the button is smaller than its implicit height.
This can happen with the global menu applet in a narrow panel.

BUG: 375911

Test Plan

Put a global menu applet in a panel, made the panel narrow. Text is vertically centered and stil readable even at the panel's minimum height

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik updated this revision to Diff 10916.Feb 4 2017, 9:52 PM
broulik retitled this revision from to [Button Styles] Use Layout.fillHeight instead of parent.height in a Layout.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R242 Plasma Framework (Library).
Restricted Application added projects: Plasma, Frameworks. · View Herald TranscriptFeb 4 2017, 9:52 PM
Restricted Application added subscribers: Frameworks, plasma-devel. · View Herald Transcript
mart accepted this revision.Feb 6 2017, 2:19 PM
mart added a reviewer: mart.
This revision is now accepted and ready to land.Feb 6 2017, 2:19 PM
Closed by commit R242:c21ff749e646: [Button Styles] Use Layout.fillHeight instead of parent.height in a Layout (authored by broulik). · Explain WhyFeb 6 2017, 2:20 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 10965

View Options

src/declarativeimports/plasmastyle/ButtonStyle.qml

Loading...
View Options

src/declarativeimports/plasmastyle/ToolButtonStyle.qml

Loading...