Differential D4432

fix FTBFS with GCC6 on arm64/armhf/ppc64el
ClosedPublic
Actions

Authored by rikmills on Feb 4 2017, 7:21 PM.

Details

Reviewers
aacid
schwarzer
Group Reviewers
KDE Games
Commits
R413:8fdc83b20270: fix FTBFS with GCC6 on arm64/armhf/ppc64el
Summary

Staging packages of 16.12.x for kubuntu failed to build from source on arm64/armhf/ppc64el where char is explicitly unsigned by default, with errors:

<<PKGBUILDDIR>>/ksirk/iris/src/xmpp/base64/base64.cpp:65:2: error: narrowing conversion of ‘-1’ from ‘int’ to ‘char’ inside { } [-Wnarrowing]

Applying a patch with this minor fix allowed successful builds on those architectures.

Test Plan

Original failing build: https://launchpad.net/~kubuntu-ppa/+archive/ubuntu/staging-kdeapplications/+sourcepub/7361168/+listing-archive-extra

Retested in staging area ppa builds, and was also successful in distribution package upload.

Ref: https://launchpad.net/ubuntu/+source/ksirk/4:16.12.1-0ubuntu1

Diff Detail

Repository
R413 KsirK
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
rikmills updated this revision to Diff 10913.Feb 4 2017, 7:21 PM
rikmills retitled this revision from to fix FTBFS with GCC6 on arm64/armhf/ppc64el.
rikmills updated this object.
rikmills edited the test plan for this revision. (Show Details)
rikmills set the repository for this revision to R413 KsirK.
rikmills edited the test plan for this revision. (Show Details)Feb 4 2017, 7:32 PM
rikmills added a reviewer: schwarzer.
aacid accepted this revision.Feb 5 2017, 7:00 PM
aacid added a reviewer: aacid.
This revision is now accepted and ready to land.Feb 5 2017, 7:00 PM
rikmills added a comment.Feb 6 2017, 8:59 AM

I don't yet have a contributor account, so could someone please push this. Thank you.

Closed by commit R413:8fdc83b20270: fix FTBFS with GCC6 on arm64/armhf/ppc64el (authored by rikmills, committed by aacid). · Explain WhyFeb 6 2017, 10:22 PM
This revision was automatically updated to reflect the committed changes.
aacid mentioned this in R413:8fdc83b20270: fix FTBFS with GCC6 on arm64/armhf/ppc64el.

Revision Contents
Changeset List

Diff 10985

View Options

ksirk/iris/src/xmpp/base64/base64.cpp

Loading...