Differential D4426

[Breeze Kstyle] Don't draw focus indicator on ComboBox entries
ClosedPublic
Actions

Authored by broulik on Feb 3 2017, 9:25 AM.

Details

Reviewers
hpereiradacosta
Group Reviewers
Plasma
Commits
R31:4d272dcbb53e: [KStyle] Don't draw focus indicator on ComboBox entries
Summary

This results in the highlight in ComboBox popups being "cut-off" (it renders a white line there) at the bottom.

Test Plan

No more white line

Before

After

Diff Detail

Repository
R31 Breeze
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik updated this revision to Diff 10891.Feb 3 2017, 9:25 AM
broulik retitled this revision from to [Breeze Kstyle] Don't draw focus indicator on ComboBox entries.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added reviewers: Plasma, hpereiradacosta.
broulik set the repository for this revision to R31 Breeze.
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 3 2017, 9:25 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
hpereiradacosta added inline comments.Feb 3 2017, 9:50 AM
kstyle/breezestyle.cpp
3071

I would rather use widget->inherits( "QComboBoxListView"). Would that work ?

broulik updated this revision to Diff 10892.Feb 3 2017, 9:52 AM

Use inherits() instead of metaObject()->className()

broulik marked an inline comment as done.Feb 3 2017, 9:52 AM
hpereiradacosta accepted this revision.Feb 3 2017, 9:53 AM
hpereiradacosta edited edge metadata.

Thanks !
Care to do the same with oxygen ? (no need for a review, just push)

This revision is now accepted and ready to land.Feb 3 2017, 9:53 AM
Closed by commit R31:4d272dcbb53e: [KStyle] Don't draw focus indicator on ComboBox entries (authored by broulik). · Explain WhyFeb 3 2017, 10:00 AM
This revision was automatically updated to reflect the committed changes.
broulik added a comment.Feb 3 2017, 10:02 AM

I can't reproduce the issue with Oxygen – does it even have the focus underline thingie?

It might be missing the fix for QQC I did [1] which caused the line to show up because I fixed/changed some offset.

[1] https://cgit.kde.org/breeze.git/commit/?id=6ecd3cad7448726807213274f66f08af79252f39

hpereiradacosta added a comment.Feb 3 2017, 10:04 AM
In D4426#82837, @broulik wrote:

I can't reproduce the issue with Oxygen – does it even have the focus underline thingie?

It might be missing the fix for QQC I did [1] which caused the line to show up because I fixed/changed some offset.

[1] https://cgit.kde.org/breeze.git/commit/?id=6ecd3cad7448726807213274f66f08af79252f39

It has the focus underline thingie (on option), but indeed the problem might not be present.
Forget it then :)
We'll fix when someone reports the issue
thanks again !

Revision Contents
Changeset List

PathPackages
Mkstyle/breezestyle.cpp (5 lines)

Diff 10893

View Options

kstyle/breezestyle.cpp

Loading...