Switch to new X-KDevelop-Languages key
ClosedPublic

Authored by kossebau on Feb 3 2017, 1:06 AM.

Details

Summary

Using "Objective-C", as it is the official name, short enough,
not too often to be types, and people seem to not agree whether
ObjC or Obj-C is a good abbr.
Removing entry from kdevcmakedocumentation, as it does not
implement ILanguageSupport.

Diff Detail

Repository
R32 KDevelop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau updated this revision to Diff 10889.Feb 3 2017, 1:06 AM
kossebau retitled this revision from to Switch to new X-KDevelop-Languages key.
kossebau updated this object.
kossebau added a reviewer: KDevelop.
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptFeb 3 2017, 1:06 AM
mwolff accepted this revision.Feb 3 2017, 5:40 PM
mwolff added a reviewer: mwolff.
mwolff added a subscriber: mwolff.

lgtm

This revision is now accepted and ready to land.Feb 3 2017, 5:40 PM
This revision was automatically updated to reflect the committed changes.
mwolff added inline comments.Feb 4 2017, 8:28 PM
languages/qmljs/kdevqmljs.json
37

this should now probably be `["QML", "JavaScript"]

kossebau added inline comments.Feb 5 2017, 4:18 PM
languages/qmljs/kdevqmljs.json
37

Not sure, does kdevqmljs support true real stand-alone JavaScript?
So can it be used to e.g. do Node.js or similar development?
Hm, blog posts hint it does:
http://milianw.de/blog/progress-on-javascript-language-support-in-kdevelop
http://steckdenis.be/post-2014-07-25-nodejs-support-in-kdevelop.html (did this even land in KDev5?)

So if yes, should be changed indeed. Though perhaps to ["QML", "JavaScript","QML/JS"], so the old identifier as used by possibly existing template files would still work. Not that I am aware of any templates though, so perhaps not worth this exception.

apol added a subscriber: apol.Feb 6 2017, 2:04 AM

Yes it does do JS alone too.

We can call the QML language QML/JS to, I don't see a problem with that. i.e. ["JS", "QML/JS"], this way you don't need the weird duplication.

Will change to ["QML/JS", "JavaScript"]then tomorrow, unless someone objects.