File template dialog: show config groups in same order as in config file
ClosedPublic

Authored by kossebau on Feb 2 2017, 5:14 PM.

Details

Summary

The config groups were passed via a QHash, which randomized the order
and prevents to define it by the options config file, as one would expect.

Diff Detail

Repository
R33 KDevPlatform
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau updated this revision to Diff 10859.Feb 2 2017, 5:14 PM
kossebau retitled this revision from to File template dialog: show config groups in same order as in config file.
kossebau updated this object.
kossebau added a reviewer: KDevelop.
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptFeb 2 2017, 5:14 PM
kossebau added inline comments.Feb 2 2017, 5:17 PM
plugins/filetemplates/templateoptionspage.cpp
137

Ah, sneaked in, should be a separate commit. Done to compact the group boxes, which would otherwise spread over the whole page.
Old:


New:

mwolff requested changes to this revision.Feb 2 2017, 10:45 PM
mwolff added a reviewer: mwolff.
mwolff added a subscriber: mwolff.

map also changes the order possibly, it sorts the entries after all

make it a variant if this really is important

This revision now requires changes to proceed.Feb 2 2017, 10:45 PM
kossebau updated this revision to Diff 10907.Feb 4 2017, 12:34 AM
kossebau edited edge metadata.

Use QVector & extend unit test to cover order of loading and correct content

kossebau updated this revision to Diff 11136.Feb 9 2017, 8:57 PM
kossebau edited edge metadata.

update to current master

mwolff accepted this revision.Feb 10 2017, 8:50 AM
mwolff edited edge metadata.

lgtm - thanks!

language/codegen/tests/test_templateclassgenerator.cpp
161

std::size? ah no, only c++17 (so not yet :-/)

This revision is now accepted and ready to land.Feb 10 2017, 8:50 AM
This revision was automatically updated to reflect the committed changes.