Always check if context is valid when calling pa functions
ClosedPublic
Actions

Authored by drosca on Feb 2 2017, 9:05 AM.

Details

Reviewers

Group Reviewers

Commits

Summary

If pa_context is null, pulseaudio aborts.

BUG: 375872

Test Plan

I can't reproduce the crash myself, but from backtrace this
should fix it.

Repository

R115 Plasma Audio Volume Applet

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

drosca retitled this revision from to Always check if context is valid when calling pa functions.

drosca updated this object.

drosca edited the test plan for this revision. (Show Details)

drosca added a reviewer: Plasma.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

This revision is now accepted and ready to land.Feb 2 2017, 11:33 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/context.h (12 lines)
M			src/context.cpp (12 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	10841	1c9f50c		Feb 2 2017, 9:05 AM	★	★
Diff 2	10847	1c9f50c	R115:1c1a76775cb566b30aa412761494116570e7c49d	Feb 2 2017, 1:25 PM	★	★