[Folder View] Open selection in preferred application instead of running them
ClosedPublic

Authored by broulik on Jan 31 2017, 2:19 PM.

Details

Summary

This makes it consistent with Dolphin which will run scripts only if one is selected. If multiple are selected, they are opened in their preferred associated application (e.g. Kate) instead.

I also removed the restriction on opening folders when only one item is selected.

CCBUG: 375793

Test Plan
  • Selected a script, hit return, got execution prompt (cf. D4367)
  • Selected two scripts, hit return, both of them were opened in Kate
  • Selected a folder, hit return, Dolphin opened it
  • Selected multiple folders, nothing happened
  • Selected multiple files and folders, only the files were opened in their associated application

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik updated this revision to Diff 10764.Jan 31 2017, 2:19 PM
broulik retitled this revision from to [Folder View] Open selection in preferred application instead of running them.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added reviewers: Plasma, hein, emmanuelp.
broulik set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma. · View Herald TranscriptJan 31 2017, 2:19 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
hein accepted this revision.Jan 31 2017, 2:42 PM
hein edited edge metadata.
This revision is now accepted and ready to land.Jan 31 2017, 2:42 PM
This revision was automatically updated to reflect the committed changes.