Differential D4361

[Containment] Move contains() check inside NDEBUG
AbandonedPublic
Actions

Authored by broulik on Jan 31 2017, 9:58 AM.

Details

Reviewers
None
Group Reviewers
Plasma
Summary

Since we don't return and only do something when NDEBUG is defined, don't do contains() for no reason.

Test Plan

Not sure how useful this thing even is since the qCDebug inside the define is commented, even..

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik updated this revision to Diff 10754.Jan 31 2017, 9:58 AM
broulik retitled this revision from to [Containment] Move contains() check inside NDEBUG.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R242 Plasma Framework (Library).
Restricted Application added projects: Plasma, Frameworks. · View Herald TranscriptJan 31 2017, 9:58 AM
Restricted Application added subscribers: Frameworks, plasma-devel. · View Herald Transcript
bshah added a subscriber: bshah.Jan 31 2017, 10:03 AM

I'd say we should port away all of the users of NDEBUG to qCDebug (if anything is still using qDebug) and remove those ifdefs..

broulik abandoned this revision.Jan 15 2018, 10:04 AM

Revision Contents
Changeset List

PathPackages
Msrc/plasma/containment.cpp (4 lines)

Diff 10754

View Options

src/plasma/containment.cpp

Loading...