[cursors] Add 36px (1.5 scaling) size for Breeze and Breeze Snow Cursors
ClosedPublic

Authored by romangg on Jan 31 2017, 1:40 AM.

Details

Summary

I use 1.5 scaling factor on my PC and the cursor sizes 24 (factor 1) and 48 (factor 2) were both not really suitable. I think adding a 1.5 cursor is a good move, since it is a common scaling factor and we only have two Breeze (Snow) cursor sizes until now anyway.

Rebuilt everything with the script, which also replaced some unnecessary copies with symlinks.

BUG: 348603 (thx to broulik)

Diff Detail

Repository
R31 Breeze
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
romangg updated this revision to Diff 10751.Jan 31 2017, 1:40 AM
romangg retitled this revision from to [cursors] Add 36px (1.5 scaling) size for Breeze and Breeze Snow Cursors.
romangg updated this object.
romangg edited the test plan for this revision. (Show Details)
romangg added a reviewer: Plasma.
romangg set the repository for this revision to R31 Breeze.
romangg added a project: Plasma.
Restricted Application added a subscriber: plasma-devel. · View Herald TranscriptJan 31 2017, 1:40 AM

Can you make sure you don't have any duplicate files and symlink them as needed?

+1 for the idea

I recall with my old 13" FullHD laptop (160 dpi) 22px was too small, 48px was too large. Back in Oxygen days my request was denied because 1.5x scaling might result in blurred lines, though.

Can you make sure you don't have any duplicate files and symlink them as needed?

Could you give me an example? I just ran the build script, which automatically should only symlink files, instead of duplicating them. Don't know, why there were duplicates before anyway. Maybe they were created with an earlier version of the script, which didn't have the symlink feature.

Btw for your stats, there's a Bug 348603 :)

romangg updated this revision to Diff 11333.Feb 14 2017, 2:58 PM
  • Now doesn't reverts changes of https://phabricator.kde.org/D3459 anymore (and supports it in build script instead of adding the symlink directly).
  • Doesn't change mode for build scripts anymore.
romangg updated this object.Feb 14 2017, 2:59 PM

I guess this is good to go?

(btw I think the credit in the BUG line will break auto-closing that bug :D)

From my side it's good to go. I thought somebody maybe wants to test it beforehand. Otherwise I can commit it tomorrow likewise.

This revision was automatically updated to reflect the committed changes.