Switch from boost::function to std::function
ClosedPublic

Authored by abrahams on Oct 21 2015, 1:36 AM.

Details

Summary

Find-and-replace for the most part, but there is no analogue of
boost::functional::factory, in stdlib, the most straighforward
replacement was C++11 lambdas.

Diff Detail

Repository
R37 Krita
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
abrahams updated this revision to Diff 1023.Oct 21 2015, 1:36 AM
abrahams retitled this revision from to Switch from boost::function to std::function.
abrahams updated this object.
abrahams edited the test plan for this revision. (Show Details)
abrahams added reviewers: dkazakov, rempt.
abrahams updated this revision to Diff 1024.Oct 21 2015, 3:43 AM

Small fix

rempt accepted this revision.Oct 21 2015, 8:58 AM
rempt edited edge metadata.

Well, yes, replacing boost with std where possible seems like a worthwhile goal. And in this case, lambda's aren't obfuscating the code much, either construct is not going to be understood by newcomers to Qt/C++. But Dmitry needs to have the last word here, since he wrote the original boost-using code.

This revision is now accepted and ready to land.Oct 21 2015, 8:58 AM
dkazakov accepted this revision.Oct 22 2015, 10:47 AM
dkazakov edited edge metadata.

The patch looks perfectly ok!

This revision was automatically updated to reflect the committed changes.