Everywhere else the code assumes plasma-pa might not be around but the config dialog would still show the check box unconditionally. Plasma-pa is not a dependency for Plasma-desktop and you can safely uninstall it (if you prefer e.g. kmix), so we should cover this case.
Details
Details
- Reviewers
hein - Group Reviewers
Plasma - Commits
- R119:d798319fee1d: [Task Manager] Enable "Mark applications that play audio" option only if plasma…
Uninstalled plasma-pa, setting was gone
Re-installed plasma-pa, setting was there again
Diff Detail
Diff Detail
- Repository
- R119 Plasma Desktop
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
Set enable property instead of visible (and always uncheck in case Plasma-pa not avail)?
Comment Actions
Maybe greyout and suggest what to install?
I'm actually fine with all three variants, but I think hiding it makes the support story harder - I imagine users talking and one can't find the check box, ...
Comment Actions
What about we gray-out the checkbox for now (5.9 series) and for master add a label explaining what's missing (open to wording suggestions)
Comment Actions
- Disable instead of hiding check box
- if not always show checkbox uncheked
Verified that enabling and disabling the checkbox still enables and disables the setting. If plasma-pa is uninstalled the checkbox stays unchecked but doesn't actually change the setting so when you install it it will magically work again.