Fix group parents not appearing when disabling inline grouping.
ClosedPublic
Actions

Authored by hein on Jan 25 2017, 6:14 PM.

Details

Reviewers

davidedmundson
broulik

Group Reviewers

Plasma

Commits

Repository

R120 Plasma Workspace

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

hein retitled this revision from to Fix group parents not appearing when disabling inline grouping..

hein updated this object.

hein edited the test plan for this revision. (Show Details)

hein added reviewers: Plasma, broulik.

hein added a subscriber: plasma-devel.

Do it properly and fix the filter instead.

Really asleep at the wheel today ...

you have
flattenGroupsProxyModel = nullptr;

after q->setSourceModel()

so does this actually work when automatic sorting is on?

(which doesn't go through forceResort())

This revision is now accepted and ready to land.Jan 25 2017, 6:40 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			libtaskmanager/tasksmodel.cpp (3 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	10564	e47a5c9		Jan 25 2017, 6:14 PM	★	★
Diff 2	10565	e47a5c9	Do it properly and fix the filter instead.	Jan 25 2017, 6:33 PM	★	★
Diff 3	10566	e47a5c9	R120:f5bf988c5bd50ec0d39e4ca4ad19ea3b25a4fbf5	Jan 25 2017, 6:33 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
f5bf988c5bd5	b441660e375d	e47a5c967834	Eike Hein	Fix group parents not appearing when disabling inline grouping. (Show More…)	Jan 25 2017, 6:13 PM