VolumeSlider: Ignore all value changes until Component is completed

Authored by drosca on Jan 24 2017, 12:58 PM.

Diff Detail

R115 Plasma Audio Volume Applet
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
drosca updated this revision to Diff 10494.Jan 24 2017, 12:58 PM
drosca retitled this revision from to VolumeSlider: Ignore all value changes until Component is completed.
drosca updated this object.
drosca edited the test plan for this revision. (Show Details)
drosca added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptJan 24 2017, 12:58 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson added inline comments.

can you not just add

if (Component.status != Ready) to the top of this method

and get rid of the bool?

drosca added inline comments.Jan 24 2017, 11:07 PM

No, because Component.status is not attached property and so is not accessible from there.

davidedmundson accepted this revision.Jan 25 2017, 12:05 AM
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.Jan 25 2017, 12:05 AM
This revision was automatically updated to reflect the committed changes.