Differential D4221

Added VcsBasicEventModel
ClosedPublic
Actions

Authored by skalinichev on Jan 20 2017, 10:20 AM.

Details

Reviewers
mwolff
apol
Group Reviewers
KDevelop
Commits
R33:b0d95189c5a4: Added VcsBasicEventModel
R32:b0d95189c5a4: Added VcsBasicEventModel
Summary

It can be used to add custom events to the model using other means then IBasicVersionControl::log

Planning to use it in kdev-mercurial to re-implement "hg heads" feature

Diff Detail

Repository
R33 KDevPlatform
Lint
Lint Skipped
Unit
Unit Tests Skipped
skalinichev updated this revision to Diff 10383.Jan 20 2017, 10:20 AM
skalinichev retitled this revision from to Added VcsBasicEventModel.
skalinichev updated this object.
skalinichev edited the test plan for this revision. (Show Details)
skalinichev added a reviewer: KDevelop.
skalinichev set the repository for this revision to R33 KDevPlatform.
skalinichev added a subscriber: kdevelop-devel.
apol added a subscriber: apol.Jan 20 2017, 3:14 PM

I'd like to see it all in place rather than just adding a class nobody uses...

skalinichev added a comment.Jan 22 2017, 10:58 AM

Implemented it just now: D4242

mwolff requested changes to this revision.Jan 22 2017, 7:53 PM
mwolff added a reviewer: mwolff.
mwolff added a subscriber: mwolff.

lgtm, just some documentation would be welcome from my side

vcs/models/vcseventmodel.cpp
151

QScopedPointer or unique_ptr

vcs/models/vcseventmodel.h
38–44

could you please add some apidox that explains the difference? the names themselves are not enough for me

This revision now requires changes to proceed.Jan 22 2017, 7:53 PM
skalinichev updated this revision to Diff 10448.Jan 23 2017, 10:43 AM
skalinichev edited edge metadata.

Added documentation

skalinichev marked 2 inline comments as done.Jan 23 2017, 10:45 AM
mwolff added inline comments.Jan 23 2017, 11:03 AM
vcs/models/vcseventmodel.h
41

This is a generic model to store a list of VcsEvents.

42

use @c

74

This model stores a list of VcsEvents corresponding to the log obtained
via IBasicVersionControl::log for a given revision. The model is populated
lazily via @c fetchMore.

77

rename to VcsEventLogModel, mention that this uses IBaseicVersionControl::log in the main api dox above

apol accepted this revision.Jan 23 2017, 11:04 AM
apol added a reviewer: apol.
skalinichev marked 4 inline comments as done.Jan 26 2017, 7:20 AM
skalinichev added inline comments.
vcs/models/vcseventmodel.h
74

Great apidox, btw! I could have never done it myself.

Closed by commit R33:b0d95189c5a4: Added VcsBasicEventModel (authored by skalinichev). · Explain WhyJan 26 2017, 7:21 AM
This revision was automatically updated to reflect the committed changes.
skalinichev marked an inline comment as done.

Revision Contents
Changeset List

PathPackages
Mvcs/models/vcseventmodel.h (46 lines)
Mvcs/models/vcseventmodel.cpp (58 lines)

Diff 10448

View Options

vcs/models/vcseventmodel.h

Loading...
View Options

vcs/models/vcseventmodel.cpp

Loading...