[Style KCM] Make sure to enable kappmenu kded module
ClosedPublic

Authored by broulik on Jan 19 2017, 9:59 AM.

Details

Summary

The old KCM enabled and disabled the kded (both autoloading and load/unloadModule) depending on global menu setting.
Since we never had global menu in 5.x before, it would disable the menu when you hit Apply.
This will break global menu for users without an obvious reason why.

Test Plan

Unloaded global menu module, hit apply, module was loaded.
Disabled global menu autoloading, hit apply, module autoloading was enabled and module was loaded.

This obviously overwrites when users disable this service but then, the service could/should always be running. It won't register a com canonical appmenu registrar service if it's not enabled, so apps will work just fine with kappmenu service running.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik updated this revision to Diff 10349.Jan 19 2017, 9:59 AM
broulik retitled this revision from to [Style KCM] Make sure to enable kappmenu kded module.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added reviewers: Plasma, ivan.
broulik set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma. · View Herald TranscriptJan 19 2017, 9:59 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart accepted this revision.Jan 19 2017, 10:45 AM
mart added a reviewer: mart.
This revision is now accepted and ready to land.Jan 19 2017, 10:45 AM
This revision was automatically updated to reflect the committed changes.