Differential D4192

File templates tool: with no open document, use base dir of project or home
ClosedPublic
Actions

Authored by kossebau on Jan 18 2017, 6:16 PM.

Details

Reviewers
mwolff
Group Reviewers
KDevelop
Commits
R32:faff287f0fbf: File templates tool: with no open document, use base dir of project or home
R33:faff287f0fbf: File templates tool: with no open document, use base dir of project or home
Summary

Currently without any document open, the base dir used for the newly
created files is an invalid empty url and in debug builds also triggers
an assert in TemplateClassGenerator constructor.

Diff Detail

Repository
R33 KDevPlatform
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau updated this revision to Diff 10334.Jan 18 2017, 6:16 PM
kossebau retitled this revision from to File templates tool: with no open document, use base dir of project or home.
kossebau updated this object.
kossebau added a reviewer: KDevelop.
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptJan 18 2017, 6:16 PM
flherne added a subscriber: flherne.Jan 20 2017, 11:35 PM

Same comment as for D4216 - with this patch too, there'd be three copies of "find if there's a single selected or active project, do something", and there are still several other features that should have consistent behaviour.

Please do factor this out before adding another copy.

kossebau added a comment.Jan 20 2017, 11:49 PM

Any proposal how to factor this out? I have no idea where exactly and how this could be added, so need some pointing.

kossebau added a comment.Jan 20 2017, 11:49 PM

Any proposal how to factor this out? I have no idea where exactly and how this could be added, so need some pointing.

mwolff accepted this revision.Jan 22 2017, 8:05 PM
mwolff added a reviewer: mwolff.
mwolff added a subscriber: mwolff.

I agree that this could share some code probably in one way or another, but I'm not too obsessed about it.

This revision is now accepted and ready to land.Jan 22 2017, 8:05 PM
mwolff added a comment.Jan 22 2017, 8:07 PM

oh and: 5.0 branch, so adding new API is probably out of the question anyways, so go for it

Closed by commit R33:faff287f0fbf: File templates tool: with no open document, use base dir of project or home (authored by kossebau). · Explain WhyJan 22 2017, 9:36 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 10441

View Options

plugins/filetemplates/filetemplatesplugin.cpp

Loading...