Differential D4181

Sonnet: segfault in trigrams generation
ClosedPublic
Actions

Authored by jsalatas on Jan 18 2017, 5:01 AM.

Details

Reviewers
mart
Group Reviewers
Plasma
Commits
R246:c7f0b1453720: Fix segfault in trigrams generation and expose MAXGRAMS constant in the header
Summary

This patch fixes a Segmentation fault in trigrams generation when weeding out trigrams.

I also moved the MAXGRAMS constant to the header file, just for consistency (gentrigrams.cpp had a hardoced value of 300).

Diff Detail

Repository
R246 Sonnet
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
jsalatas updated this revision to Diff 10308.Jan 18 2017, 5:01 AM
jsalatas retitled this revision from to Sonnet: segfault in trigrams generation.
jsalatas updated this object.
jsalatas edited the test plan for this revision. (Show Details)
jsalatas added a reviewer: Plasma.
jsalatas set the repository for this revision to R246 Sonnet.
Restricted Application added projects: Plasma, Frameworks. · View Herald TranscriptJan 18 2017, 5:01 AM
Restricted Application added subscribers: Frameworks, plasma-devel. · View Herald Transcript
mart accepted this revision.Jan 18 2017, 10:15 AM
mart added a reviewer: mart.
This revision is now accepted and ready to land.Jan 18 2017, 10:15 AM
Closed by commit R246:c7f0b1453720: Fix segfault in trigrams generation and expose MAXGRAMS constant in the header (authored by jsalatas). · Explain WhyJan 18 2017, 9:53 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 10336

View Options

data/CMakeLists.txt

Loading...
View Options

data/gentrigrams.cpp

Loading...
View Options

src/core/guesslanguage.h

Loading...
View Options

src/core/guesslanguage.cpp

Loading...