Differential D4176

Don't re-evaluate the model constantly whilst looping through windows
ClosedPublic
Actions

Authored by davidedmundson on Jan 17 2017, 6:55 PM.

Details

Reviewers
broulik
Group Reviewers
Plasma
Commits
R871:517be8484a80: Don't re-evaluate the model constantly whilst looping through windows
R120:517be8484a80: Don't re-evaluate the model constantly whilst looping through windows
Summary

We only want to set the menu to unavailable when we've searched all the
transient windows and found there is no menu, not whilst we are looping.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson updated this revision to Diff 10294.Jan 17 2017, 6:55 PM
davidedmundson retitled this revision from to Don't re-evaluate the model constantly whilst looping through windows.
davidedmundson updated this object.
davidedmundson edited the test plan for this revision. (Show Details)
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptJan 17 2017, 6:55 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik accepted this revision.Jan 17 2017, 8:55 PM
broulik added a reviewer: broulik.
This revision is now accepted and ready to land.Jan 17 2017, 8:55 PM
Closed by commit R120:517be8484a80: Don't re-evaluate the model constantly whilst looping through windows (authored by davidedmundson). · Explain WhyJan 17 2017, 8:57 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 10301

View Options

applets/appmenu/plugin/appmenumodel.cpp

Loading...