Generate DBusMenu Interface for libdbusmenuqt
ClosedPublic
Actions

Authored by davidedmundson on Jan 17 2017, 2:38 PM.

Details

Reviewers

Group Reviewers

Commits

R120:9d58703d3725: Generate DBusMenu Interface for libdbusmenuqt
R871:9d58703d3725: Generate DBusMenu Interface for libdbusmenuqt

Summary

This not only makes the code cleaner but more importantly avoids plasma
making a blocking DBus call to a client in the QDBusInterface constructor
which does a blocking call to Introspect

Test Plan

Ran my test app with the dynamic menu. Everything was still fine

Diff Detail

Repository

R120 Plasma Workspace

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

davidedmundson updated this revision to Diff 10283.Jan 17 2017, 2:38 PM

davidedmundson retitled this revision from to Generate DBusMenu Interface for libdbusmenuqt.

davidedmundson updated this object.

davidedmundson edited the test plan for this revision. (Show Details)

davidedmundson added a reviewer: Plasma.

Restricted Application added a project: Plasma. · View Herald TranscriptJan 17 2017, 2:38 PM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

apol accepted this revision.Jan 17 2017, 2:40 PM

apol added a reviewer: apol.

This revision is now accepted and ready to land.Jan 17 2017, 2:40 PM

Doesn't compile:

make[2]: *** No rule to make target: "../libdbusmenuqt/com.canonical.dbusmenu.xml", needed by "libdbusmenuqt/dbusmenu_interface.cpp"

Add .xml file

Closed by commit R120:9d58703d3725: Generate DBusMenu Interface for libdbusmenuqt (authored by davidedmundson). · Explain WhyJan 17 2017, 8:57 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		libdbusmenuqt/CMakeLists.txt (8 lines)
A	M	libdbusmenuqt/com.canonical.dbusmenu.xml (49 lines)
M		libdbusmenuqt/dbusmenuimporter.h (1 line)
M		libdbusmenuqt/dbusmenuimporter.cpp (25 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	10283	6ed2c4a		Jan 17 2017, 2:38 PM	★	★
Diff 2	10292	6ed2c4a	Add .xml file	Jan 17 2017, 5:08 PM	★	★
Diff 3	10300	6ed2c4a	R120:9d58703d37257e363ca27282b56caef3092ec5d0	Jan 17 2017, 5:08 PM	★	★