Differential D4166

Fix pixel alignment and non-standard height in QuickShare delegate
ClosedPublic
Actions

Authored by davidedmundson on Jan 16 2017, 10:16 PM.

Details

Reviewers
apol
Group Reviewers
Plasma
Commits
R114:407168327b93: Fix pixel alignment and non-standard height in QuickShare delegate
Summary

The current code had height: button.height * 1.2
then centered the button within it, which can result in non-pixel
aligned y values, leading to rendering issues.

We don't need to specify the height explicitly, it's done by ListItem if
we fix the underlying binding loop. This gives the delegate the correct
size of button height + margins.

BUG: 375137

Diff Detail

Repository
R114 Plasma Addons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson updated this revision to Diff 10259.Jan 16 2017, 10:16 PM
davidedmundson retitled this revision from to Fix pixel alignment and non-standard height in QuickShare delegate.
davidedmundson updated this object.
davidedmundson edited the test plan for this revision. (Show Details)
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptJan 16 2017, 10:16 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
apol accepted this revision.Jan 16 2017, 10:32 PM
apol added a reviewer: apol.
apol added a subscriber: apol.

Thanks!

This revision is now accepted and ready to land.Jan 16 2017, 10:32 PM
Closed by commit R114:407168327b93: Fix pixel alignment and non-standard height in QuickShare delegate (authored by davidedmundson). · Explain WhyJan 16 2017, 10:35 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 10260

View Options

applets/quickshare/plasmoid/contents/ui/ShareDialog.qml

Loading...