[User Switcher] Just use Row's implicitWidth instead of calculating it manually
ClosedPublic
Actions

Authored by broulik on Jan 16 2017, 1:58 PM.

Details

Reviewers

davidedmundson

Group Reviewers

Plasma

Commits

Summary

I don't know what I was thinking when I implemented this but just use implicitWidth which is the correct width.

Fixes the label potentially being wider than the applet swallowing the right panel margin when placed at the end of a panel.

Test Plan

Tried in all modes (label only, icon only, label+icon) and the width was correct every time.

Repository

R114 Plasma Addons

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

broulik retitled this revision from to [User Switcher] Just use Row's implicitWidth instead of calculating it manually.

broulik updated this object.

broulik edited the test plan for this revision. (Show Details)

broulik added a reviewer: Plasma.

broulik set the repository for this revision to R114 Plasma Addons.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

This revision is now accepted and ready to land.Jan 16 2017, 2:04 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			applets/userswitcher/package/contents/ui/main.qml (4 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	10237			Jan 16 2017, 1:57 PM	★	★
Diff 2	10238	3ec2ae7	R114:dc6948230f1f7f1c9618df3822e12c6dbe6ecc2e	Jan 16 2017, 2:04 PM	★	★