Network manager configuration model is unreadable
AbandonedPublic

Authored by jsalatas on Jan 16 2017, 7:24 AM.

Details

Reviewers
jgrulich
Group Reviewers
Plasma: Design
Plasma
Summary

It seems that for some application/plasma theme combinations (bug #374905) and also form 3rd party themes (bug #374976), the new network manager configuration model is unreadable.

The attached seems to correctly handle all cases of Breeze and Breeze dark application/plasma theme combinations, however the result doesn't look (always) aesthetically pleasant. Is there a better way yo do it? :\

Test Plan

Breeze dark application scheme, Breeze dark Plasma theme

Breeze dark application scheme, Breeze light Plasma theme

Breeze light application scheme, Breeze light Plasma theme

Breeze light application scheme, Breeze dark Plasma theme

Diff Detail

Repository
R116 Plasma Network Management Applet
Lint
Lint Skipped
Unit
Unit Tests Skipped
jsalatas updated this revision to Diff 10203.Jan 16 2017, 7:24 AM
jsalatas retitled this revision from to Network manager configuration model is unreadable.
jsalatas updated this object.
jsalatas edited the test plan for this revision. (Show Details)
jsalatas set the repository for this revision to R116 Plasma Network Management Applet.
Restricted Application added a project: Plasma. · View Herald TranscriptJan 16 2017, 7:24 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
jsalatas updated this revision to Diff 10204.Jan 16 2017, 7:28 AM

Previous diff was incomplete.

jgrulich edited edge metadata.Jan 16 2017, 7:32 AM

I decided to try a different approach before we try to find a color which fits to all combinations (plasma theme + application color). I'm trying to get rid of Plasma QML components so it uses same colors which are used by the rest of application.

I'm trying to get rid of Plasma QML components so it uses same colors which are used by the rest of application.

I guess that would be a better approach as it seems that plasma and application themes don't always mix well.

Here

is patch using my approach, but there is still problem with icons. Given that icons are only available from plasma theme and we don't use colors from plasma theme anymore, then icons won't be visible when you use combination of light plasma theme and dark application color or vice versa. Any idea how to solve this?

Icons problem solved

. Can you please test this patch?

Icons problem solved

. Can you please test this patch?

Perfect!!!! :)

BTW: I don't know how I did it but while testing it, at some point configuration didn't open at all and plasma produced the following error

"kcmshell5 with modules ' "org.kde.kcmshell_kcm_networkmanagement.desktop" ' is already running."

I cannot reproduce it and it may be related to the crash that happens from time to time when you close the configuration window :\

jsalatas abandoned this revision.Jan 16 2017, 9:06 AM