Differential D4125

Use asynchronous calls to the device interface when possible
ClosedPublic
Actions

Authored by apol on Jan 13 2017, 5:05 PM.

Details

Reviewers
albertvaka
Group Reviewers
KDE Connect
Commits
R224:b947ef6b60bf: Use asynchronous calls to the device interface when possible
Summary

Use setWhenAvailable for isTrusted calls
Just deal with the pairing buttons state only once.
Unify semantics (paired vs trusted)

Diff Detail

Repository
R224 KDE Connect
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol updated this revision to Diff 10150.Jan 13 2017, 5:05 PM
apol retitled this revision from to Use asynchronous calls to the device interface when possible.
apol updated this object.
apol edited the test plan for this revision. (Show Details)
apol added reviewers: KDE Connect, albertvaka.
apol updated this revision to Diff 10151.Jan 13 2017, 5:09 PM

Correct semantics

albertvaka accepted this revision.Jan 13 2017, 5:10 PM
albertvaka edited edge metadata.

Cool!

This revision is now accepted and ready to land.Jan 13 2017, 5:10 PM
Closed by commit R224:b947ef6b60bf: Use asynchronous calls to the device interface when possible (authored by apol). · Explain WhyJan 13 2017, 5:50 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkcm/kcm.h (1 line)
Mkcm/kcm.cpp (30 lines)

Diff 10153

View Options

kcm/kcm.h

Loading...
View Options

kcm/kcm.cpp

Loading...